Skip to content

revert: refactor: native zlib support #10314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2024
Merged

revert: refactor: native zlib support #10314

merged 1 commit into from
Jun 2, 2024

Conversation

Jiralite
Copy link
Member

@Jiralite Jiralite commented Jun 2, 2024 •
edited
Loading

This reverts commit 20258f9.

This is to ensure discord.js gets #10271 through a non-breaking version.

@Jiralite Jiralite requested a review from a team as a code owner June 2, 2024 18:31
@vercel Vercel
Copy link

vercel bot commented Jun 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Jun 2, 2024 6:31pm
discord-js-guide ⬜️ Ignored (Inspect) Jun 2, 2024 6:31pm

vladfrangu
vladfrangu approved these changes Jun 2, 2024
View reviewed changes
Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We love temporary reverts

@codecov Codecov
Copy link

codecov bot commented Jun 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 18.33333% with 49 lines in your changes are missing coverage. Please review.

Project coverage is 18.92%. Comparing base (aae2faf) to head (6856fc9).

Files Patch % Lines
packages/ws/src/ws/WebSocketShard.ts 14.03% 49 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##             main   #10314       +/-   ##
===========================================
- Coverage   95.89%   18.92%   -76.98%     
===========================================
  Files          44       31       -13     
  Lines        3634     6156     +2522     
  Branches      283       73      -210     
===========================================
- Hits         3485     1165     -2320     
- Misses        149     4991     +4842
Flag Coverage Δ
brokers 18.92% <18.33%> (-76.98%) ⬇️
builders 18.92% <18.33%> (-76.98%) ⬇️
collection 18.92% <18.33%> (-76.98%) ⬇️
discord.js 18.92% <18.33%> (-76.98%) ⬇️
formatters 18.92% <18.33%> (-76.98%) ⬇️
guide 18.92% <18.33%> (-76.98%) ⬇️
next 18.92% <18.33%> (-76.98%) ⬇️
proxy 18.92% <18.33%> (-76.98%) ⬇️
rest 18.92% <18.33%> (-76.98%) ⬇️
util 18.92% <18.33%> (-76.98%) ⬇️
utilities 18.92% <18.33%> (-76.98%) ⬇️
voice 18.92% <18.33%> (-76.98%) ⬇️
website 18.92% <18.33%> (-76.98%) ⬇️
ws 18.92% <18.33%> (-76.98%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jiralite Jiralite changed the title revert: native zlib support revert: refactor: native zlib support Jun 2, 2024
@Jiralite Jiralite added this to the ws 1.2.0 milestone Jun 2, 2024
@kodiakhq kodiakhq bot merged commit 4ea73bb into main Jun 2, 2024
24 checks passed
@kodiakhq kodiakhq bot deleted the revert/10243 branch June 2, 2024 19:53
@sdanialraza sdanialraza mentioned this pull request Jun 2, 2024
Merged
kodiakhq bot added a commit that referenced this pull request Jun 2, 2024
@sdanialraza @kodiakhq
refactor: native zlib support (#10316)
94cc02a 
Revert "revert: refactor: native zlib support (#10314)"

This reverts commit 4ea73bb.

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@almeidx almeidx almeidx approved these changes

@didinele didinele Awaiting requested review from didinele didinele is a code owner automatically assigned from discordjs/ws

Assignees
No one assigned
Labels
packages:ws
Projects
discord.js
Archived in project
Milestone
ws 1.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Jiralite @vladfrangu @iCrawl @almeidx